Skip to content

Conversation

Flamefire
Copy link
Contributor

In super-builds show the CMake version which is especially useful on CI to verify the used CMake and/or compare different jobs on failure.

Limited to the super build to not be too verbose when Boost is used via add_subdirectory or similar.

In super-builds show the CMake version which is especially useful on CI to verify the used CMake and/or compare different jobs on failure.

Limited to the super build to not be too verbose when Boost is used via `add_subdirectory` or similar.
@nigels-com
Copy link

Good idea! Would be helpful.

@pdimov
Copy link
Member

pdimov commented Sep 11, 2025

  1. pull requests should be against develop
  2. logic such as this goes into BoostRoot.cmake, to keep CMakeLists.txt minimal

@Flamefire
Copy link
Contributor Author

pull requests should be against develop

Can/Shall we change the default branch to develop? When opening a pull request here it defaulted to the master branch instead and I forgot to verify

@Flamefire Flamefire closed this Sep 11, 2025
@Flamefire Flamefire deleted the patch-1 branch September 11, 2025 13:38
@pdimov
Copy link
Member

pdimov commented Sep 11, 2025

The default branch here is kept on master so that people doing get clone --recurse-submodules get that instead of develop which is going to be much less stable.

@Flamefire
Copy link
Contributor Author

logic such as this goes into BoostRoot.cmake, to keep CMakeLists.txt minimal

--> boostorg/cmake#88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants